This repository was archived by the owner on Mar 3, 2026. It is now read-only.
fix: make dependency on request explicit#361
Merged
JustinBeckwith merged 1 commit intomasterfrom Sep 6, 2018
Merged
Conversation
Somehow we got away without including request as dependency. Making that implicit so we don't run into problems when pubsub updates. npm ls request @google-cloud/storage@2.0.0 /Users/franzih/code/gcp/nodejs-storage ├─┬ @google-cloud/pubsub@0.19.0 │ ├─┬ @google-cloud/common@0.16.2 │ │ ├─┬ google-auto-auth@0.9.7 │ │ │ └── request@2.88.0 deduped │ │ ├── request@2.88.0 deduped │ │ └─┬ retry-request@3.3.2 │ │ └── request@2.88.0 deduped │ └─┬ google-auto-auth@0.10.1 │ └── request@2.88.0 deduped ├─┬ codecov@3.0.2 │ └── request@2.88.0 └─┬ gcs-resumable-upload@0.12.0 └── request@2.88.0 deduped
googlebot
added
the
cla: yes
ghost
assigned
alexander-fenster
approved these changes
Sep 6, 2018
Contributor
alexander-fenster
left a comment
alexander-fenster
left a comment
There was a problem hiding this comment.
What's up with Kokoro Windows build?
Contributor
Author
|
@crwilcox do you know if the Windows build is configured and expected to work? |
JustinBeckwith
approved these changes
Sep 6, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Somehow we got away without including request as dependency. Making
that implicit so we don't run into problems when pubsub updates.
Prerequisite for #207 so we can switch to smaller HTTP dependency.